Code Review Thoughts

We recently had our code review by Dr. Stonedahl. The code review was basically a way to ensure that we are coding things up in an efficient way. We had focused on ensuring our login was clean and effective. 

We are using Android Studio to code our project, but we don't have much experience with it. Thus, we used the Login Activity (picture shown below) for the login. However, since we are also using Google's Firebase, we decided to use the Google Login. Following this tutorial, we managed to create a simple sign in where the user can use either Gmail or regular email sign in. However, since we are using Google's Firebase, then there are many more sign in options that we chose not to use. 
 
Login Activity Creation Page











This login activity focused on having all of the login information done locally, on the device within the app. Thus, it created a plethora of classes that were unnecessary for our project because we were attempting to use the Google Sign in which can be done in the cloud instead of the device.  

Even though we decided not to use it, this login activity is super helpful for those trying to understand how to sign in works in general. Moreover, it allows the app developer to create their own sign in process. Using Google's sign in, we are only allowed to do what Google allows and all of the information gets sent to Google since we are using the cloud to store our users. 

This relates to our code review because Dr. Stonedahl helped us understand what the Login Activity from Android Studio was doing and ensured that our project was able to work without the classes and activities that it auto generated when we added the Login Activity to our project. 

Our Sign in Screen

Comments